Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrades for Vector{ZZLat} #4775

Conversation

antonydellavecchia
Copy link
Collaborator

missed upgrading vectors of types whose params were upgraded.

@antonydellavecchia
Copy link
Collaborator Author

Still issue with loading tmpOG10.txt

julia> load("/home/antonydv/Downloads/tmpOG10.txt")
┌ Warning: Attempted loading file stored using a DEV version with commit 8795e0f5719119e18ebbadc07b0c4022819a60e0
└ @ Oscar ~/projects/Oscar/src/Serialization/main.jl:804
ERROR: Expected dimension 6 x 6, got 12 x 12

@antonydellavecchia
Copy link
Collaborator Author

antonydellavecchia commented Apr 2, 2025

closes #4774

@StevellM
Copy link
Member

StevellM commented Apr 2, 2025

Thanks! So both files from the issue can be opened now ? I have another file somewhere I could send you to check whether this one could be read also. In the future I will make sure to use tuples, or separated files.

@antonydellavecchia
Copy link
Collaborator Author

Thanks! So both files from the issue can be opened now ? I have another file somewhere I could send you to check whether this one could be read also. In the future I will make sure to use tuples, or separated files.

with my latest push both files load

@StevellM
Copy link
Member

StevellM commented Apr 3, 2025

Perfect! Looks like I can open other files in the same situation. Thank you.

Copy link
Member

@StevellM StevellM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go, if someone can merge this, it would be great.

@thofma thofma merged commit 9ff58c8 into master Apr 5, 2025
33 checks passed
@thofma thofma deleted the 4774-serialization-cannot-deserialize-files-saved-before-the-last-major-refactoring branch April 5, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization: cannot deserialize files saved before the last major refactoring
3 participants