Oscar Worker Pool and parallel functions functionality such as pmap.

[HechtiDerLachs]

Ping @antonydellavecchia

[afkafkafk13]

I just read through your PR and I am definitely interested in this functionality. I left you a few comments on the documentation -- which simply reflect what came to my mind, when reading the PR out of curiosity.

[afkafkafk13]

you might actually want to (exceptionally) point the interested programmer to this file for a minimal working example.

[antonydellavecchia]

It seems that the following snippet we copied to lines to 220 to 236 is not supported in julia 1.6

  # Copied from Distributed.jl/src/workerpool.jl.
  # This puts the worker back to the pool once the future is ready
  # and we do not have to worry about this ourselves.
  local fut
  try
    fut = remotecall(f, wid, args...; kwargs...)
  catch
    put!(wp, wid)
    rethrow()
  end
  t = Threads.@spawn Threads.threadpool() try
    wait(fut)
  catch
  finally
    put!(wp, wid)
  end
  errormonitor(t)

Which appears to handle putting the workers back to the pool better, and is supported in 1.10 since the tests pass for 1.10.

and it seems that the code in Distributed/src/workerpool.jl for julia 1.6 (below), doesn't work for 1.11

   worker = take!(pool)
    try
        rc_f(f, worker, args...; kwargs...)
    finally
        put!(pool, worker)
    end

So it seems we would need to drop support for 1.6 to merge this PR, thoughts @fingolfin @benlorenz ?

[thofma]

So it seems we would need to drop support for 1.6 to merge this PR, thoughts @fingolfin @benlorenz ?

Can't you make a branch depending on VERSION?

[antonydellavecchia]

So it seems we would need to drop support for 1.6 to merge this PR, thoughts @fingolfin @benlorenz ?

Can't you make a branch depending on VERSION?

it wont compile in julia 1.6

So it seems we would need to drop support for 1.6 to merge this PR, thoughts @fingolfin @benlorenz ?

Can't you make a branch depending on VERSION?

It wont compile so branching wont work

ERROR: LoadError: LoadError: LoadError: LoadError: MethodError: no method matching var"@spawn"(::LineNumberNode, ::Module, ::Expr, ::Expr)
Closest candidates are:
  var"@spawn"(::LineNumberNode, ::Module, ::Any) at threadingconstructs.jl:166

I can try and see if i can replace threadpool with something would work in both?

[thofma]

Try putting two different methods at the toplevel using @static if VERSION <=. For example

@static if VERSION <= 1.0
  function bla(x)
  end
else
  function bla(x)
  end
end

[benlorenz]

Looks good and seems to work fine, thanks!