-
Notifications
You must be signed in to change notification settings - Fork 139
Add highest_root(R::RootSystem)
for convenience
#4789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add highest_root(R::RootSystem)
for convenience
#4789
Conversation
Is the highest weight a well-defined concept for redicuble root systems? If not, it would be good to restrict this to irreducible types. |
I addressed my comments. Could you please have another look @felix-roehrich ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4789 +/- ##
==========================================
+ Coverage 84.57% 84.73% +0.16%
==========================================
Files 676 681 +5
Lines 91285 91554 +269
==========================================
+ Hits 77201 77579 +378
+ Misses 14084 13975 -109
🚀 New features to boost your workflow:
|
No description provided.