Skip to content

Add highest_root(R::RootSystem) for convenience #4789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

felix-roehrich
Copy link
Collaborator

No description provided.

@joschmitt joschmitt added topic: lie theory release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Apr 6, 2025
@lgoettgens
Copy link
Member

lgoettgens commented Apr 6, 2025

Is the highest weight a well-defined concept for redicuble root systems? If not, it would be good to restrict this to irreducible types.
And I think this should get exported.
(I'll come back to you latest after my vacation)

@lgoettgens lgoettgens self-requested a review April 6, 2025 15:35
@lgoettgens
Copy link
Member

I addressed my comments. Could you please have another look @felix-roehrich ?

Copy link
Collaborator Author

@felix-roehrich felix-roehrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks.

@lgoettgens lgoettgens closed this Apr 17, 2025
@lgoettgens lgoettgens reopened this Apr 17, 2025
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (c2562fc) to head (9e9eff8).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4789      +/-   ##
==========================================
+ Coverage   84.57%   84.73%   +0.16%     
==========================================
  Files         676      681       +5     
  Lines       91285    91554     +269     
==========================================
+ Hits        77201    77579     +378     
+ Misses      14084    13975     -109     
Files with missing lines Coverage Δ
src/LieTheory/RootSystem.jl 85.50% <100.00%> (+0.74%) ⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: lie theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants