updates to oscar worker pool to allow abstract cluster managers #5660
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonydellavecchia
added
the
release notes: use title
benlorenz
reviewed
Dec 19, 2025
| return new(wp, wp.channel, wp.workers, wids, Dict{Int, RemoteChannel}()) | ||
| end | ||
|
|
||
| function OscarWorkerPool(manager::ClusterManager; project=nothing, kw...) |
Member
There was a problem hiding this comment.
Suggested change
| function OscarWorkerPool(manager::ClusterManager; project=nothing, kw...) | |
| function OscarWorkerPool(manager::ClusterManager; project=Base.active_project(), kw...) |
The active project is I think a reasonable default, and matches what happens for local workers.
This way one could still manually pass nothing to avoid this step if needed.
| There is also the option to use an `OscarWorkerPool` within a context, | ||
| such that closing down the processes happens automatically. | ||
| Will also accept a `manager` as an argument, `kw` will get passed to `addprocs` when initializing the workers. |
Member
There was a problem hiding this comment.
Can you add a sentence explaining the project keyword as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.