test: cover Claude ultra no-op, Codex excludeUltra, mobile Priority - #150
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: cover Claude ultra no-op, Codex excludeUltra, mobile Priority#150cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Lock regressions for mid-session Codex ultra on Claude, Claude Codex-sub catalog rows that must drop ultra, and the mobile home-composer Priority toggle synthesized from fast-only variants (#146). Co-authored-by: oscarlehuu <oscarlehuu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daily coverage pass for recently merged risky paths that lacked direct regression tests: Claude mid-session Codex
ultrahandling, Claude Codex-sub catalogexcludeUltra, and the mobile home-composer Priority toggle synthesized from fast-only variants (#146).Tiny testability extract only — mobile option synthesis moved into a pure helper; no user-facing behavior change.
Risky behavior now covered
ultrano-op —setModelwitheffort/reasoningEffort: 'ultra'must not callapplyFlagSettings(ClaudeeffortLevelhas no ultra tier).excludeUltra—defaultCodexReasoningEffortOption({ excludeUltra: true })drops Multi-agent ultra from Claude Codex-sub picker rows (fix(server): drop Codex 'ultra' tier from Codex-sub rows in the Claude picker #143).fastvia fast-only variants, the Options sheet synthesizes a Priority boolean toggle (fix(mobile): surface fast (Priority) toggle from model variants #146).Test files added/updated
apps/server/test/unit/agents/claude-agent.provider.spec.ts— ultra skip casesapps/server/test/unit/agents/codex-model-options.spec.ts—excludeUltraunit caseapps/mobile/src/lib/model-option-descriptors.ts+.spec.ts— extracted helper + 5 specsapps/mobile/src/components/home-composer.tsx— uses the helper (behavior-preserving)Why these tests materially reduce regression risk
effortLevel: 'ultra'mid-session can break live query flag updates for Codex-sub sessions.Changes
excludeUltracomposerModelOptionDescriptorsfor deterministic mobile coverage of fix(mobile): surface fast (Priority) toggle from model variants #146Type
Checklist
model-option-descriptors.spec.ts(5 pass)<!-- no-changeset -->; test + behavior-preserving extract)Test plan
Related issues / PRs
Refs #143, #146. Follow-up to coverage automation #142.
Screenshots / recordings
N/A