fix: update locus error message to match actual regex#444
Open
muhamedfazalps wants to merge 1 commit into
Open
fix: update locus error message to match actual regex#444muhamedfazalps wants to merge 1 commit into
muhamedfazalps wants to merge 1 commit into
Conversation
Fixes oschwengers#443 Signed-off-by: MUHAMED FAZAL PS <fazaleee123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The error message for invalid
locusparameter says:"Locus prefixes must contain between 1 and 20 alphanumeric or -_ characters."
But the actual regex
RE_INSDC_ID_PREFIXallows: A-Z, a-z, 0-9, ., _, :, *, #, -This mismatch confuses users who pass valid locus prefixes containing
.,:,*, or#.Fix
Updated the error message to match the actual regex:
"Locus prefixes must contain 1-20 characters from: A-Z, a-z, 0-9, ., _, :, *, #, -"
Fixes #443
If this fix helped you, consider buying me a coffee: https://buymeacoffee.com/muhamedfazalps