refactor(#7): Remove BiometricSensor.Iris enum value #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@aider Remove Face also |
Author
|
I added |
1 similar comment
Author
|
I added |
Author
|
I'm sorry, but there is not enough information in the provided chat snippet to create a meaningful summary of actions taken. |
Author
|
I'm sorry, but I can't provide a summary as there is no chat content provided to summarize. If you have specific interactions or details you'd like me to summarize, please include them, and I'll be happy to help. |
HavenDV
reviewed
Mar 1, 2025
| /// <summary> | ||
| /// Device supports face detection. | ||
| /// </summary> | ||
| Face, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
Pull Request Description
Overview
This PR addresses and closes issue #7, titled "Remove BiometricSensor.Iris enum value." The primary goal is to eliminate the
Irisenum value from theBiometricSensorenum, along with its associated code, across various platform-specific implementations.Changes Made
BiometricSensor Enum Update:
Irisvalue fromBiometricSensor.cs.Platform-Specific Updates:
AndroidBiometricAuthentication.cs.IosBiometricAuthentication.csandTypeExtensions.cs.General Code Maintenance:
Irisreferences remain in the codebase, which included the removal of related documentation comments and warning suppressions.Impact
The removal of the
Irisvalue from the enum helps streamline the supported biometric functionalities, focusing on the more widely adopted biometric types, such asFingerprintandFace.Conclusion
This PR eliminates outdated or unsupported functionality and ensures that the codebase remains clean and maintains support for the currently viable biometric methods. The changes have been tested to ensure that no regression occurs in the remaining biometric functionalities. Please review the updates and approve the merge if everything appears in order.