-
Notifications
You must be signed in to change notification settings - Fork 18
Fix Ansible-lint issues without rule var-naming[no-role-prefix] on skip_list #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sbstnnmnn
wants to merge
22
commits into
main
Choose a base branch
from
test_ansible-lint-6.22.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93499d3 to
d8690c6
Compare
4ab23a7 to
fce6478
Compare
ddb8f24 to
d3075ec
Compare
sbstnnmnn
commented
Jan 29, 2024
a315d60 to
7d88e2e
Compare
816fccc to
bf22ea8
Compare
68f1393 to
e536ca8
Compare
e536ca8 to
09fe709
Compare
…ements" This reverts commit 09fe709. Signed-off-by: Sebastian Neumann <[email protected]>
7262790 to
6ea3f66
Compare
Signed-off-by: Robin van der Linden <[email protected]>
81b4680 to
4d6629f
Compare
Signed-off-by: Robin van der Linden <[email protected]>
4d6629f to
abd85c1
Compare
Signed-off-by: Sebastian Neumann <[email protected]>
13352ea to
cc8c00e
Compare
Signed-off-by: Sebastian Neumann <[email protected]>
cc8c00e to
d72af98
Compare
Signed-off-by: Sebastian Neumann <[email protected]>
Signed-off-by: Sebastian Neumann <[email protected]>
e135cda to
07dd7d1
Compare
Signed-off-by: Sebastian Neumann <[email protected]>
07dd7d1 to
b6dea09
Compare
Signed-off-by: Sebastian Neumann <[email protected]>
1826815 to
625118a
Compare
….22.2 requirements Signed-off-by: Sebastian Neumann <[email protected]>
625118a to
abf241f
Compare
Signed-off-by: Sebastian Neumann <[email protected]>
lindenb1
approved these changes
Feb 5, 2024
Contributor
lindenb1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. osism/issues#829