frr: add VRRP support for leaf configuration #2035
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow configuring arbitrary VRRP-managed IP addresses in the frr_leaf configuration via the new frr_vrrp_groups variable. This enables defining multiple VRRP groups with IPv4 and IPv6 addresses, priority, and preempt settings. AI-assisted: Claude Code Signed-off-by: Christian Berendt <[email protected]>
osfrickler
reviewed
Dec 9, 2025
| interface {{ vrrp_group.interface }} | ||
| vrrp {{ vrrp_group.vrid }}{% if vrrp_group.ipv6 | default([]) | length > 0 %} version 3{% endif %} | ||
|
|
||
| {% if vrrp_group.priority | default(false) %} |
Member
There was a problem hiding this comment.
actually the default should be 100 according to the comment above? better make this explicit instead of relying on FRR's default?
| {% if vrrp_group.priority | default(false) %} | ||
| vrrp {{ vrrp_group.vrid }} priority {{ vrrp_group.priority }} | ||
| {% endif %} | ||
| {% if vrrp_group.preempt | default(true) == false %} |
| ! | ||
| {% for vrrp_group in frr_vrrp_groups %} | ||
| interface {{ vrrp_group.interface }} | ||
| vrrp {{ vrrp_group.vrid }}{% if vrrp_group.ipv6 | default([]) | length > 0 %} version 3{% endif %} |
Member
There was a problem hiding this comment.
version 3 is the default and can be used for both v4+v6, no need to add the extra logic
| # Example: | ||
| # frr_vrrp_groups: | ||
| # - interface: eth0 | ||
| # vrid: 10 |
Member
There was a problem hiding this comment.
this name seems confusing to me, just id should be fine? otherwise vrrp_id?
|
|
||
| frr_extra_interfaces: [] | ||
|
|
||
| # VRRP configuration for leaf nodes |
Member
There was a problem hiding this comment.
... for routers instead of leaf nodes?
| # priority: 100 # optional, default 100 | ||
| # preempt: true # optional, default true | ||
| # ipv4: | ||
| # - 192.168.1.1/24 |
Member
There was a problem hiding this comment.
this parameter needs to be only the IP, no netmask
| # - 192.168.1.1/24 | ||
| # - 192.168.1.2/24 | ||
| # ipv6: # optional | ||
| # - 2001:db8::1/64 |
|
|
||
| frr_enable_bgpd: "yes" | ||
| frr_enable_bfdd: "no" | ||
| frr_enable_vrrpd: "no" |
Member
There was a problem hiding this comment.
change this to "yes" automatically if frr_vrrp_groups is non-empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring arbitrary VRRP-managed IP addresses in the frr_leaf configuration via the new frr_vrrp_groups variable. This enables defining multiple VRRP groups with IPv4 and IPv6 addresses, priority, and preempt settings.
AI-assisted: Claude Code