Make bind/designate usable via wireguard #2579
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Berendt <[email protected]>
osfrickler
reviewed
Feb 4, 2025
Member
osfrickler
left a comment
osfrickler
left a comment
There was a problem hiding this comment.
I'm a bit unsure on this one, it isn't good operational practice to mix authoritative servers with forwarders. I fear people may try to see this as a blueprint for production deployments. can we maybe at least not activate it by default?
Member
Author
|
I would do it the other way round. A note in the file + in the documentation that it is not best practice and that it is explicitly for the testbed. Then you can deactivate it when using the configuration if you don't want it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.