-
-
Notifications
You must be signed in to change notification settings - Fork 24
feat: Add support for 'podman-compose' in sugar #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…th handling in podman-ext command
…h string and list types
…for improved compatibility
…nd usage and improved error handling
…hancing error handling and configuration parsing
@sanjay7178 , do we really need to have a new extension for podman? or could we just add support to it with |
Actually I found out few interesting things that really required the podman as seperate command in sugar
conclusion :
|
@sanjay7178 , I will review that tomorrow. thanks! |
This pull request has been marked as stale because it has been |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on that @sanjay7178 !
in general it looks good to me.
I just added comments about some code that was commented out .. that probably should be removed.
please ping me on discord when you have fixed the commented code.
sure |
Pending Chores :
|
here is the mkdocs live preview this PR https://sugar-podman.pages.dev/podman-ext/ |
…tal status and key features
@sanjay7178 , the documentation looks great. please let me know on inc-sugar where this PR is ready for a review. thanks! |
…tal status and key features
…om SugarPodmanComposeExt
@sanjay7178 could you rebase your branch on top of the upstream/main? |
Sure |
LGTM! thanks @sanjay7178 for working on that. appreciate it |
🎉 This PR is included in version 1.17.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This PR implements support for
podman-compose
commands in Sugar, expanding its capabilities beyond Docker Compose.Solve #166
How to test these changes
This PR is a:
environment :
Reference :
PR Checklist:
podman-compose
pypi package to poetrySugar Podman-Ext CLI Specific Checklist :
- [ ] ls List running compose projects.- [ ] top Display the running processes.Observation from podman-compose and docker-compose :