Skip to content

Conversation

ryanmcd118
Copy link
Collaborator

This PR is a follow-up to the recent [ #96 ] functional changes, focusing specifically on performance and stability improvements identified during post-merge review and Lighthouse audits. It reduces initial JS work, shrinks network payloads, and fixes a webpack asset naming conflict. It also restores proper navbar image rendering and maintains full test coverage.

Changes

  • Added proper viewport meta tag and removed unused logo preload.
  • Lazy-loaded heavy UI components (React Flow, CodeMirror) with React.Suspense while preserving test stability.
  • Restored navbar logos to correct size via CSS; enabled async decoding.
  • Enabled bundle splitting and fixed dev/prod filename collisions in webpack.
  • Updated tests to handle async loading.

Impact

  • Performance: Faster LCP/FCP by deferring non-critical scripts and splitting chunks.
  • Stability: Eliminated asset name conflicts and 404s.
  • UI: Clean, correctly sized navbar logos.

Verification

  • npm run dev → app loads without filename conflicts; navbar logos render correctly; no 404s.
  • Lazy-loaded components appear when triggered.
  • npm run lint and NODE_ENV=test npm test → all tests pass.

ryanmcd118 and others added 2 commits August 15, 2025 16:05
Improve performance and stability with lazy-loading, bundle splitting, and UI fixes
@ryanmcd118 ryanmcd118 self-assigned this Aug 15, 2025
@ryanmcd118 ryanmcd118 added bug Something isn't working enhancement New feature or request labels Aug 15, 2025
Copy link
Collaborator Author

@ryanmcd118 ryanmcd118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryanmcd118 ryanmcd118 marked this pull request as ready for review August 15, 2025 20:55
@ryanmcd118 ryanmcd118 merged commit 59099b1 into oslabs-beta:main Aug 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant