Add 3x sprite sheets - #1246
Open
ZeLonewolf wants to merge 20 commits into
Open
Conversation
ZeLonewolf
commented
Aug 3, 2025
Comment on lines
+33
to
+47
| const generated: SpriteSheetResult[] = await Sprites.generate( | ||
| sprites, | ||
| [1, 2, 3] | ||
| ); | ||
|
|
||
| for (const result of generated) { | ||
| const scaleText: string = | ||
| result.pixelRatio === 1 ? "" : `@${result.pixelRatio}x`; | ||
| const outputPng: string = `${opts.output}/sprite${scaleText}.png`; | ||
| const outputJson: string = `${opts.output}/sprite${scaleText}.json`; | ||
|
|
||
| await fs.writeFile(outputPng, result.buffer); | ||
| await fs.writeFile(outputJson, JSON.stringify(result.layout, null, 2)); | ||
| const kb: string = (result.buffer.length / 1024).toFixed(1); | ||
| console.log(`Wrote ${kb}KiB to ${outputPng}`); |
Member
Author
There was a problem hiding this comment.
The main change is here. I now pass in an array [1,2,3] and generate sprites in a loop. Easy extension to 4x if we ever need it.
ZeLonewolf
marked this pull request as ready for review
August 3, 2025 00:31
Member
Previously tracked in mapbox/mapbox-gl-native#1008. Not sure if this has ever been requested of MapLibre GL JS. Most of the codebase theoretically supports arbitrary pixel densities, but the code that parses URL formats assumes all HiDPI sprites have “2x” in the URL. QGIS also hard-codes 2× as the maximum resolution. |
ZeLonewolf
marked this pull request as draft
August 21, 2025 01:54
ZeLonewolf
marked this pull request as ready for review
August 29, 2025 21:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sprite sheets for 3x pixel ratios, which is needed for newer iPhones.