Skip to content

Make low-zoom highways use OpenMapTiles defaults - #1271

Draft
ZeLonewolf wants to merge 14 commits into
mainfrom
zlw-canada-roads
Draft

Make low-zoom highways use OpenMapTiles defaults#1271
ZeLonewolf wants to merge 14 commits into
mainfrom
zlw-canada-roads

Conversation

@ZeLonewolf

@ZeLonewolf ZeLonewolf commented Sep 23, 2025

Copy link
Copy Markdown
Member

This PR does the following:

  • Adds z4 trunk roads in OpenMapTiles to render, with the same style as motorway
  • Remove the road layer opacity block, which was not used/necessary
  • Simplify the fill color logic for trunk roads
  • Remove toll selectors for zooms <9 where toll attributes aren't in the underlying tiles

Before:
image

After:
image

@adamfranco

Copy link
Copy Markdown
Collaborator

Not sure if it's appropriate for this issue or a new one, but now that low-zoom trunks in the Trans-Canada highway are being displayed at z4, the brightness of the red for trunk looks more impactful than the motorway color:
Screenshot 2025-09-23 at 2 16 50 PM

at z5 the extra width of motorways makes them closer in terms of visual impact
Screenshot 2025-09-23 at 2 19 46 PM

and by z6 motorways look much more impactful.
Screenshot 2025-09-23 at 2 20 49 PM

The reason I mention this is that maybe the opacity lines that were removed maybe need to stay, but have the opacity gradient changed to not completely eliminate roads.

@ZeLonewolf ZeLonewolf left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the color is wrong in this PR (hence still draft), but it's showing what roads should be shown at z4.

@ZeLonewolf
ZeLonewolf marked this pull request as draft September 25, 2025 03:06
@ZeLonewolf ZeLonewolf changed the title [Draft] Make low-zoom highways use OpenMapTiles defaults Make low-zoom highways use OpenMapTiles defaults Sep 27, 2025
@ZeLonewolf
ZeLonewolf marked this pull request as ready for review September 27, 2025 03:52
@adamfranco

Copy link
Copy Markdown
Collaborator

This is looking quite good, with one little potential issue.

Right at z4, the trunks are super faint: https://preview.americanamap.org/pr/1271/#map=4/43.59/-92.5\
Screenshot 2025-09-28 at 7 18 16 PM

By z4.5 they are reasonably visible: https://preview.americanamap.org/pr/1271/#map=4.49/45.65/-91.07
Screenshot 2025-09-28 at 7 21 53 PM

Is that the behavior you are intending?

@ZeLonewolf

Copy link
Copy Markdown
Member Author

Ugh, looks like I regressed something

@ZeLonewolf
ZeLonewolf marked this pull request as draft September 29, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants