-
Notifications
You must be signed in to change notification settings - Fork 79
Adjusting park labels #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wmisener
wants to merge
4
commits into
osm-americana:main
Choose a base branch
from
wmisener:wmisener/parks_adjustments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Adjusting park labels #1302
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6aa3980
Decreasing font from bold to regular
wmisener a5dadab
Merge branch 'main' into wmisener/parks_adjustments
wmisener 2d46f92
Merge branch 'main' into wmisener/parks_adjustments
wmisener 4db665c
Merge branch 'osm-americana:main' into wmisener/parks_adjustments
wmisener File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we’re boldfacing labels of other fills without icons, such as ponds, at high zoom levels, whereas most POIs end up in normal weight because we only label them as points with icons. I think this is a useful treatment to keep. Can we vary the font by zoom level? Note that you’d need to use a
literalexpression inside each stop of aninterpolateorstepexpression.