Apply request timeouts while waiting for a connection #3827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOMINATIM_REQUEST_TIMEOUTallows to restrict the maximum runtime of a query. Until now it only applied to the actual processing part of the query. Before that part starts, the client has to get a database connection from the connection pool. When a server gets overloaded and the request queue gets overly full, then it can take a long time before a connection is available. This can easily lead to situations where Nominatim only gets to process queries where the client has long given up waiting for a response.This PR changes the meaning of the parameter and also applies it to the time spent waiting for a connection. If the timeout hits before a connection is available a
TimeoutError(or HTTP 503) is returned. If the timeout then hits later while the query is being processed, the available requests will be returned as before.