-
-
Notifications
You must be signed in to change notification settings - Fork 795
chore: update no,nb,nn country-names translation #3836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update no,nb,nn country-names translation #3836
Conversation
settings/country-names/by.yaml
Outdated
| nl: Wit-Rusland | ||
| nn: Kviterussland | ||
| "no": Hviterussland | ||
| nn: Belarus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
settings/country-names/fm.yaml
Outdated
| lt: Mikronezija | ||
| lv: Mikronēzija | ||
| mn: Микронези | ||
| nb: Mikronesiaføderasjonen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mikronesia is the region, Mikronesiaføderasjonen is the country.
|
Thanks for looking into keeping these names up to date. For the country additions, see the comment in #3837. Any keys "no" need to be surrounded by double qoutes or yaml will interpret them as "false". The rules around "nb" are apparently complicated in OSM. Basically it says to use 'name:nb'/'name:nn' only when the spellings differ, otherwise just use |
08542e7 to
5683c78
Compare
Agree! Removed them now 😁
Fixed!
Hehe, yeah. nn, nb and no are always fun in every i18n project I have seen 😅 I could definitely update the configs to follow that schema! Just a quick question first; how does the fallback logic work? |
|
There currently is no fallback logic in Nominatim, somewhat under the assumptions that Norwegian speakers are aware that they better provide fallbacks in their language preferences. ;) I would take a PR to add a fallback. Somwhere around here there should be there should be a special case to add 'no' if 'nn' or 'nb' appear without 'no' being in the list. |
5683c78 to
f50f51b
Compare
Sounds good! |
843f0fd to
335bce0
Compare
lonvia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost good now, there is just the minor complaint about abbreviations. Also, please squash the commits into one and force push the result.
If Norwegian needs abbreviation forms like "saint" -> "st", then this would need to go into https://github.com/osm-search/Nominatim/blob/master/settings/icu-rules/variants-no.yaml Something for another PR to look at.
335bce0 to
0285494
Compare
Nice catch! Removed abbreviations 😄
I think I already did that? 👀 Should just have been one commit I force pushed as I made changes. Thanks for the patience and the feedback! |
0285494 to
58d570c
Compare
|
Thanks for patiently revising this PR. The CI failure is unrelated and already fixed on an upcoming branch of mine. |
Update and add missing translations for:
Also removed nn and nb values where the "no" value was matching. Ref: https://wiki.openstreetmap.org/wiki/Multilingual_names#Norway
Development process: