Skip to content

Conversation

@Johannes-Andersen
Copy link
Contributor

@Johannes-Andersen Johannes-Andersen commented Sep 11, 2025

Update and add missing translations for:

  • Norwegian (no)
  • Norwegian Bokmål (nb)
  • Norwegian Nynorsk (NN)

Also removed nn and nb values where the "no" value was matching. Ref: https://wiki.openstreetmap.org/wiki/Multilingual_names#Norway

Development process:

nl: Wit-Rusland
nn: Kviterussland
"no": Hviterussland
nn: Belarus
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lt: Mikronezija
lv: Mikronēzija
mn: Микронези
nb: Mikronesiaføderasjonen
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mikronesia is the region, Mikronesiaføderasjonen is the country.

@lonvia
Copy link
Member

lonvia commented Sep 12, 2025

Thanks for looking into keeping these names up to date.

For the country additions, see the comment in #3837.

Any keys "no" need to be surrounded by double qoutes or yaml will interpret them as "false".

The rules around "nb" are apparently complicated in OSM. Basically it says to use 'name:nb'/'name:nn' only when the spellings differ, otherwise just use name:no. This seems a reasonable rule to follow. The result would rather mean removing a couple of the name:nn though.

@Johannes-Andersen Johannes-Andersen force-pushed the chore/i18NorwegianCountries branch 3 times, most recently from 08542e7 to 5683c78 Compare September 12, 2025 08:55
@Johannes-Andersen
Copy link
Contributor Author

Johannes-Andersen commented Sep 12, 2025

For the country additions, see the comment in #3837.

Agree! Removed them now 😁

Any keys "no" need to be surrounded by double qoutes or yaml will interpret them as "false".

Fixed!

The rules around "nb" are apparently complicated in OSM. Basically it says to use 'name:nb'/'name:nn' only when the spellings differ, otherwise just use name:no. This seems a reasonable rule to follow. The result would rather mean removing a couple of the name:nn though.

Hehe, yeah. nn, nb and no are always fun in every i18n project I have seen 😅

I could definitely update the configs to follow that schema! Just a quick question first; how does the fallback logic work?
Example if someone where to just set nn or nb and not no, or if someone has they language set to nb and only nn is set

@lonvia
Copy link
Member

lonvia commented Sep 12, 2025

There currently is no fallback logic in Nominatim, somewhat under the assumptions that Norwegian speakers are aware that they better provide fallbacks in their language preferences. ;) I would take a PR to add a fallback. Somwhere around here there should be there should be a special case to add 'no' if 'nn' or 'nb' appear without 'no' being in the list.

@Johannes-Andersen Johannes-Andersen force-pushed the chore/i18NorwegianCountries branch from 5683c78 to f50f51b Compare September 12, 2025 10:31
@Johannes-Andersen
Copy link
Contributor Author

There currently is no fallback logic in Nominatim, somewhat under the assumptions that Norwegian speakers are aware that they better provide fallbacks in their language preferences. ;) I would take a PR to add a fallback. Somwhere around here there should be there should be a special case to add 'no' if 'nn' or 'nb' appear without 'no' being in the list.

Sounds good!
Went ahead and ran a quick script to do some cleanup 😄

@Johannes-Andersen Johannes-Andersen force-pushed the chore/i18NorwegianCountries branch 2 times, most recently from 843f0fd to 335bce0 Compare September 12, 2025 10:45
Copy link
Member

@lonvia lonvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost good now, there is just the minor complaint about abbreviations. Also, please squash the commits into one and force push the result.

If Norwegian needs abbreviation forms like "saint" -> "st", then this would need to go into https://github.com/osm-search/Nominatim/blob/master/settings/icu-rules/variants-no.yaml Something for another PR to look at.

@Johannes-Andersen Johannes-Andersen force-pushed the chore/i18NorwegianCountries branch from 335bce0 to 0285494 Compare September 12, 2025 14:39
@Johannes-Andersen
Copy link
Contributor Author

If Norwegian needs abbreviation forms like "saint" -> "st", then this would need to go into master/settings/icu-rules/variants-no.yaml Something for another PR to look at.

Nice catch! Removed abbreviations 😄

Also, please squash the commits into one and force push the result.

I think I already did that? 👀 Should just have been one commit I force pushed as I made changes.
Let me know if I need to change anything :D

Thanks for the patience and the feedback!

@Johannes-Andersen Johannes-Andersen force-pushed the chore/i18NorwegianCountries branch from 0285494 to 58d570c Compare September 12, 2025 16:21
@lonvia lonvia merged commit 77ed463 into osm-search:master Sep 12, 2025
6 of 8 checks passed
@lonvia
Copy link
Member

lonvia commented Sep 12, 2025

Thanks for patiently revising this PR. The CI failure is unrelated and already fixed on an upcoming branch of mine.

@Johannes-Andersen Johannes-Andersen deleted the chore/i18NorwegianCountries branch September 12, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants