Force inclusion of extra tags when Nominatim internally depends on them #3861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of tags in the 'extratags' column of a place on which Nominatim depends internally: place, wikipedia, wikidata, capital. When writing a custom style, you had to manually ensure that these tags are included. That can lead to bad surprises.
This PR changes lua processing, so that all tags that Nominatim depends on internally are always included independent of what the style says. The line
is no longer required and will in fact throw an error. If you have this in your custom style, just delete the line.