Add NOT NULL and UNIQUE contraints on tables #3939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds NOT NULL and UNIQUE constraints to SQL tables consistently were possible. These constraints may allow PostgreSQL to optimise execution and helps catching subtle errors in the SQL code. The PR includes some fixes for these kinds of errors:
The PR also makes sure that indexed_status is only set to 1 when a place is newly added. This allows to skip deleting data from secondary tables for new data, shaving off about 5% of the import time.
Finally fixes an issue in the BDD test with the randomly generated names sometimes not being valid and improves termination when an error occurs during indexing.