change_clickable_Ways_centring #5130
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RZR-UA
reviewed
Dec 25, 2025
| NSString *tag2 = [self getOsmTag2]; | ||
| NSString *val2 = [self getOsmValue2]; | ||
| if (tag2 && val2) | ||
| tags[tag1] = val1; |
RZR-UA
reviewed
Dec 26, 2025
| return _osmId >> AMENITY_ID_RIGHT_SHIFT; | ||
| } | ||
|
|
||
| - (NSDictionary<NSString *, NSString *> *)getOsmTags |
Contributor
There was a problem hiding this comment.
getOsmTags in Java returns LinkedHashMap - so here we must use OrderedDictionary as result
RZR-UA
reviewed
Dec 26, 2025
Comment on lines
+195
to
+196
| NSDictionary<NSString *, NSString *> *osmTags = [amenity getOsmTags]; | ||
| MutableOrderedDictionary<NSString *, NSString *> *tags = [[MutableOrderedDictionary alloc] initWithDictionary:osmTags]; |
Contributor
There was a problem hiding this comment.
How randomized dictionary made ordered? It seems wrong.
RZR-UA
reviewed
Dec 26, 2025
Comment on lines
+871
to
+873
| //TODO: is this correct place to this code launch? | ||
| [ClickableWayHelper openClickableWayAmenityWithAmenity:poi adjustMapPosition:YES]; | ||
| return YES; |
Contributor
There was a problem hiding this comment.
It seems a wrong way to openClickableWayAmenity if multiple ClickableWay found in foundBinaryMapObjects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/osmandapp/OsmAnd-Issues/issues/2873