Add "Dashed line" track appearance option#25243
Open
rustyqt wants to merge 1 commit into
Open
Conversation
Adds a per-track "Dashed line" switch to the track Appearance editor. When enabled, the track is drawn as a dashed line. - New LINE_DASHED GpxParameter (boolean), persisted in the gpx database (DB version 36 -> 37 migration adds the column) and in the GPX file <extensions> as "line_dashed". - DashedLineCard in the appearance editor; persisted per saved track and for the current recording track (CURRENT_TRACK_LINE_DASHED). - Rendering reuses the existing VectorLine setLineDash pipeline; a Renderable.setDashed() change-detector rebuilds the geometry on toggle. Dash length is proportional to the line width.
Author
|
Member
|
We will need to review UI cause some options won't be possible or desirable like dash + gradient |
Member
|
Nice addition for solid color |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a per-track Dashed line option to the track Appearance editor. When enabled, the track is rendered as a dashed line instead of solid.
Why
A simple, frequently-wished way to visually distinguish tracks (e.g. planned vs. recorded, variants) without changing colour or width.
How
Mirrors the existing
SHOW_ARROWSappearance option end-to-end:LINE_DASHEDGpxParameter(boolean):DB_VERSION36 → 37; the genericonUpgradecolumn-add migrates both the gpx and gpx-dir tables,<extensions>asline_dashed(GpxFile.isLineDashed()/setLineDashed()).DashedLineCard(BaseSwitchCard) added toTrackAppearanceFragment, next to "Direction arrows". Persisted on save for saved tracks and for the current recording track (CURRENT_TRACK_LINE_DASHED).TrackDrawInfocarries the flag;GpxAppearanceHelper.isLineDashedForTrack(...)resolves it (editor → current track → DB → GPX file).GPXLayersupplies a width-proportional dash pattern toRenderableSegment.drawGeometry(...), which already feedsVectorLineBuilder.setLineDash(...)for the OpenGL core. A smallRenderable.setDashed()change-detector (mirroringsetDrawArrows) makes a toggle rebuild the geometry.Notes
androidFull/opengl/arm64).PULL_REQUEST.MIT.LICENSE).🤖 Generated with Claude Code