-
Notifications
You must be signed in to change notification settings - Fork 341
Navigation UI #1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Navigation UI #1321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements improvements to the Navigation UI, focusing on enhanced marker click handling and better user experience when interacting with navigation inputs. The changes enable users to click on map markers (favorites, POI, explore items) to set navigation points, add better focus management for history dropdowns, and improve the overall navigation workflow.
Key changes:
- Added marker click-to-navigate functionality across Favorite, POI, and Explore layers that automatically fills navigation inputs when markers are clicked
- Refactored navigation point selection logic into a centralized NavigationManager module
- Improved focus and state management for navigation history dropdowns with better keyboard and mouse interaction handling
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
tests/selenium/src/tests/navigation/46-navigation-favorite-marker-click.mjs |
New test validating favorite marker clicks populate navigation inputs |
tests/selenium/src/tests/navigation/45-navigation-history.mjs |
Updated test to verify history dropdown closing behavior |
tests/selenium/src/tests/navigation/43-navigation-save-download.mjs |
Added navigation title click for proper UI state management |
map/src/store/navigationObject/navigationObject.js |
Enhanced waypoint parsing with fallbacks for icon and name properties from different sources |
map/src/resources/translations/en/web-translation.json |
Added location disabled message for better user feedback |
map/src/menu/navigation/routemenu.module.css |
Updated styles for clear button positioning and history item spacing |
map/src/menu/navigation/NavigationSettings.jsx |
Applied consistent styling to navigation settings items |
map/src/menu/navigation/NavigationMenu.jsx |
Added URL profile parameter handling with loading state and moved pickNextRoutePoint function |
map/src/menu/navigation/NavigationInputRow.jsx |
Refactored to manage history dropdown state at row level with drag state awareness |
map/src/menu/navigation/NavigationInput.jsx |
Simplified by moving history dropdown to parent component and improved focus handling |
map/src/menu/navigation/NavigationHistoryDropdown.jsx |
Enhanced current location handling to show item even when disabled, with notification feedback |
map/src/map/util/TrackLayerProvider.js |
Added type parameter to prevent GPX waypoint clicks from being handled as navigation points |
map/src/map/layers/PoiLayer.js |
Added navigation marker click event dispatching for POI markers |
map/src/map/layers/NavigationLayer.js |
Refactored to use refs and callbacks for better performance and added custom event listener support |
map/src/map/layers/FavoriteLayer.js |
Added navigation marker click event dispatching for favorite markers |
map/src/map/layers/ExploreLayer.js |
Added navigation marker click event dispatching for explore markers |
map/src/manager/NavigationManager.js |
New centralized module for navigation constants and utility functions |
map/src/infoblock/components/wpt/actions/locationActions.js |
Updated imports to use centralized navigation constants |
map/src/graph/plugins/distanceXAxisPlugin.js |
Fixed number formatting to avoid trailing zeros in distance labels |
map/src/frame/components/items/SelectItemRadio.jsx |
Added className prop for custom styling support |
map/src/frame/components/items/SelectItemBoolean.jsx |
Added className prop for custom styling support |
map/src/frame/components/items/DefaultItem.jsx |
Added className prop for custom styling support |
map/src/frame/components/btns/ActionIconBtn.jsx |
Changed default iconColor to blue with imported constant available |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.