GitHub Action comment on PR #11706
GitHub Action comment on PR #11706
Conversation
|
Hey cool, it looks like this worked! |
|
I'm not that optimistic, I see 2 errors on the previous actions, checkout and push. https://github.com/osmlab/name-suggestion-index/actions/runs/20575891067/job/59092694308 I wonder if the push is because was on forks, not a branch within the repo. Checkout, IDK. |
|
Push may or may not be a permissions thing https://stackoverflow.com/questions/73687176/permission-denied-to-github-actionsbot-the-requested-url-returned-error-403#answer-75175628 |
|
So checkout of forks is fixed, but it's basically impossible to commit to them (without secrets everywhere). We could:
I'm not in love with comments, especially because main will still end up in an unbuilt state, and the comments will be too noisy. |
|
|
||
| on: | ||
| pull_request: | ||
| pull_request_target: |
There was a problem hiding this comment.
This is naughty if NSI has secrets in GitHub, they can be leaked by PRs
| with: | ||
| add_options: '-A' | ||
| message: | | ||
| ```diff |
There was a problem hiding this comment.
Some words would be good
There was a problem hiding this comment.
| ```diff | |
| The following changes will be applied before NSI is released, your changes may have unintended consequences. | |
| ```diff |
|
Spending the "morning" on this has demotivated me a bit, but I would still like to see main be constantly clean, or close to it. Having another action build main and open a PR for review (or commit straight to main) every day/week/hour should be significantly easier, I've done similar before, it's possible. It shouldn’t get in the way of rapidly merging PRs occasionally, and if the existing action is changed to comment, the comments would stay relevant. |
Rel: #11646 (comment)