Skip to content

Add link to github#25

Open
tordans wants to merge 1 commit into
osmlab:gh-pagesfrom
tordans:patch-1
Open

Add link to github#25
tordans wants to merge 1 commit into
osmlab:gh-pagesfrom
tordans:patch-1

Conversation

@tordans

@tordans tordans commented Aug 5, 2020

Copy link
Copy Markdown

Add a footer that links to this repo, so it can be easily found from the website.
Also extract the #history-div that is used by JS, so the footer does get in its way.

It looks like this:
image

Add a footer that links to this repo, so it can be easily found from the website.
Also extract the #history-div that is used by JS, so the footer does get in its way.
@iandees

iandees commented Aug 5, 2020

Copy link
Copy Markdown
Member

I like the idea of linking to the GitHub repo, but having it under the tag list makes it look like it's part of the OSM data. Can it be moved up to the header? Maybe in the upper right corner?

@tordans

tordans commented Aug 5, 2020

Copy link
Copy Markdown
Author

On my screen (width) that would be cluttered and could be interpreted as part of the header.

I thought the footer-gray styling makes it different enough to not be confused as content.

But maybe an icon instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants