Brest advertising board - update self.def_class_

[XioNoX]

To obtain the existing objects change suggestions, and not only the new objects suggestions

[XioNoX]

analyser_merge_advertising_board_FR_Brest-france_bretagne_finistere.json

Current output (renamed from .gejson).

[frodrigo]

This change will only detect exiting objet with access=yes. I not understand why you want to make that.

[XioNoX]

Yeah I think I misunderstand something :)

It looks like some data is missing, and I was trying to figure out what's going on.
Running it locally I get from the .geojson (taking one semi-randomly)

        {
            "type": "Feature",
            "geometry": {
                "type": "Point",
                "coordinates": [
                    -4.478451799999998,
                    48.39436560000001
                ]
            },
            "properties": {
                "class": 4,
                "subclass": "1412293571633414781",
                "text": {},
                "ids": [
                    9481372247,
                    "N",
                    "POINT(-4.478451799999998 48.39436560000001)",
                    {
                        "access": "yes",
                        "source": "data.gouv.fr:Brest M\u00e9tropole - 2025-05",
                        "message": "opinions;non_profit;showbiz",
                        "animated": "no",
                        "man_made": "advertising",
                        "advertising": "board",
                        "land_property": "public"
                    },
                    {
                        "advertising": "board"
                    },
                    {
                        "URL": "https://www.google.com/maps?z=14&t=m&q=48.39438001322516,-4.478323283281108&layer=c&cbll=48.39438001322516,-4.478323283281108&cbp=11,0,0,0,0",
                        "DEPCO": "29019",
                        "NUMERO": "19",
                        "HAUTEUR": "0.00",
                        "LARGEUR": "0.00",
                        "OLD_NUM": "0",
                        "SURFACE": "0.0",
                        "X_COORD": "147239",
                        "Y_COORD": "6836649",
                        "ogc_fid": "140",
                        "QUARTIER": "Centre Ville",
                        "ID_PANNEAU": "29019_1613",
                        "LOCALISATI": "Angle Y Collet-rue Saint Martin"
                    }
                ],
                "types": [
                    "node",
                    null
                ],
                "fix": {
                    "+": {
                        "access": "yes",
                        "source": "data.gouv.fr:Brest M\u00e9tropole - 2025-05",
                        "message": "opinions;non_profit;showbiz",
                        "animated": "no",
                        "man_made": "advertising",
                        "land_property": "public"
                    },
                    "~": {},
                    "-": []
                }
            }
        },

While it doesn't seem to show up on the map or osmose UI.

In other words osmose only seem to show the addition of new nodes, but not updating existing ones.

[frodrigo]

Use this 3 output https://github.com/osm-fr/osmose-backend/blob/dev/analysers/analyser_merge_post_box_FR.py#L30-L35

def_class_update_official is a special case you do not need.

[XioNoX]

Thanks, I tried once more, but I feel like I'm getting more confused :)
Hopefully this one is the good one.

[frodrigo]

Sorry, def_class_update_official is the right one.

The issue is with static1 and static2. The content of static2 is not part of update, even if is different or non present in OSM. The 2 part (staitc or mapping) are for less important tags. The goal is to avoid boring the Osmose users with less important tags.

[XioNoX]

Thanks, there is unfortunately something else wrong.

If we take the node in that comment : #2508 (comment)
Which is https://www.openstreetmap.org/node/9481372247 and only have the tag advertising=board in OSM.

It is also present in the OpenData.

I've set the below static1 in my code, so the "access": "yes" should trigger the integration.

static1={"advertising": "board",
               "access": "yes"},

Which seems to work in the OSMOSE generated .geojson :

                "fix": {
                    "+": {
                        "access": "yes",
                        "source": "data.gouv.fr:Brest M\u00e9tropole - 2025-05",
                        "message": "opinions;non_profit;showbiz",
                        "animated": "no",
                        "man_made": "advertising",
                        "land_property": "public"
                    },
                    "~": {},
                    "-": []

But it doesn't show that suggestion in OSMOSE's UI.