Skip to content

Conversation

@flacombe
Copy link
Contributor

@flacombe flacombe commented Sep 4, 2025

I propose the following improvements of classes documentation and add details for class 8

@flacombe
Copy link
Contributor Author

flacombe commented Sep 4, 2025

I don't understand the tests results:

    def dump_class(self, classs):
        for id_ in classs:
            data = classs[id_]
            self.error_file.classs(
                id = id_,
>               item = data['item'],
                level = data['level'],
                tags = data.get('tags'),
                title = data.get('title'),
                detail = data.get('detail'),
                fix = data.get('fix'),
                trap = data.get('trap'),
                example = data.get('example'),
                source = data.get('source'),
                resource = data.get('resource'),
            )
E           TypeError: tuple indices must be integers or slices, not str

It's in Analyser_osmosis.py without change

Copy link
Collaborator

@Famlam Famlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some English suggestions

@frodrigo
Copy link
Contributor

frodrigo commented Nov 1, 2025

@flacombe could you review the last comments, please ?

@frodrigo
Copy link
Contributor

@flacombe still interested in this ?

@flacombe
Copy link
Contributor Author

Hello @frodrigo @Famlam thank you for comments.
Most of them has been reviewed and integrated in the recent update.

You can close remaining threads if you think corresponding problems are fixed

@frodrigo frodrigo marked this pull request as draft December 17, 2025 17:09
@frodrigo frodrigo marked this pull request as ready for review December 17, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants