-
Notifications
You must be signed in to change notification settings - Fork 129
add mapcss from PowerQA ValidateMyGrid #2601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I had troubles with the rules that use the link selector, that is apparently not supported in Osmose mapcss: even with the mapcss: |
|
Can I get a review please 🙏 ? |
Should be here, but it is not https://github.com/osmose-qa/osmose-backend/blob/dev/mapcss/MapCSS.g4#L171 In any case, this will not be supported by the Osmose MapCSS implementation, as Osmose use Plugin as MapCSS backend that check only one object at the time. |
|
🤔 hum, there is a bunch of unrelated commits in this PR (with conflicts on translations totally unrelated to my works), I'm note sure why ... |
|
Try to rebase and remove unrelated commits from the branch. |
|
So big. Have you try to run it on Osmose, or just generated it ? |
|
yes, I did test the generated plugin on france_ile_de_france_val_de_marne. |
This PR add a mapcss ruleset about power grid & power generation, that is already packaged and available for JOSM.
source code: https://github.com/open-energy-transition/validate-my-grid
doc: https://wiki.openstreetmap.org/wiki/Power_networks/Quality_Assurance
The translations for the rules and the Osmose doc is intended to be in the validate-my-grid repo too, following the same models as Jungle Bus transport_mapcss ruleset (but it will come later, there are no translations in the repo for now)
#MapYourGrid