Deduplicate tx in default mempool insert#3
Merged
iboss-ptk merged 1 commit intorelease/v2.x.xfrom Aug 19, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current
DefaultMempoollacks duplicate detection, causing transactions with the same transaction to accumulate and hit capacity limits. This led to "failed to insert tx into mempool: pool reached max tx capacity" errors after upgrading to v2.1.7-mempool.Solution
Replaced simple array-based implementation with linked list + hash map implementation such that it detects duplicated tx on insert while maintaining O(1) time complexity and improves time complexity for other operations (Remove -> O(1), Contains -> O(1))