feat: fastusdc bridge provider #4074
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samsiegart is attempting to deploy a commit to the OsmoLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoseRFelix
requested changes
May 6, 2025
samsiegart
commented
May 7, 2025
There was a problem hiding this comment.
Thanks for reviewing. We aligned with Aaron that this could be made the default. How do you suggest we address that in this PR? A few possibilities:
- We hardcode
bestQuoteto prioritize the fast usdc provider ID if available - We change
bestQuoteto prioritize the fastest quote instead of the cheapest (similar to https://go.skip.build/ which seems to default to fastest) - We change
bestQuoteto balance speed and price based on some formula. Basically, formalize in some way that it's better to pay a little extra to go from 18 minutes to 1 minute.
|
@samsiegart Thanks for the suggestions and for checking in! We discussed this internally with management and the team, and for now, we’ve decided to stick with the current approach. While we see the potential benefits of prioritizing speed, making it the default introduces trade-offs we’re not ready to take on at this stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change:
Adds Fast USDC as a supported bridge for USDC to Osmosis.
Brief Changelog
Testing and Verifying
This change has been tested locally by rebuilding the website and verified content and links are expected
Demo Video: https://drive.google.com/file/d/1Di35UFs5W4ES_4eM9sDTKBrhVUo8xcnl/view?usp=sharing