Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
- run: |
cat ./*profile.out | grep -v "mode: atomic" >> coverage.txt
if: env.GIT_DIFF
- uses: codecov/codecov-action@v3
- uses: codecov/codecov-action@v6
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated file parameter won't work in v6

High Severity

The codecov/codecov-action was bumped from v3 to v6, but the file input parameter was deprecated in v5 and replaced with files. The workflow still uses file: ./coverage.txt, which means the specified coverage file may be silently ignored, causing the coverage upload to either fail or upload auto-discovered files instead of the intended coverage.txt.

Fix in Cursor Fix in Web

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required token after bump to v6

High Severity

Bumping codecov/codecov-action from v3 to v6 introduces a breaking change: tokenless uploads were removed in v4. The workflow does not pass a token parameter, and CODECOV_TOKEN is not referenced anywhere in the repository. Without providing token: ${{ secrets.CODECOV_TOKEN }}, the coverage upload step will fail for non-fork PRs and push events to master/release/** branches.

Fix in Cursor Fix in Web

with:
file: ./coverage.txt
if: env.GIT_DIFF
Loading