Closed
Conversation
13 tasks
iboss-ptk
force-pushed
the
rebalancing_incentive_calculation
branch
from
78ad42c to
d5fe090
Compare
crnbarr93
approved these changes
Nov 5, 2024
Collaborator
crnbarr93
left a comment
crnbarr93
left a comment
There was a problem hiding this comment.
LGTM! Just a potential small comment change. Will need to evaluate how these functions are implemented in the rest of the contract but it looks like that'll be a separate PR.
| /// $$ | ||
| /// C(b) = | ||
| /// \begin{cases} | ||
| /// \left(\frac{b - \phi_l}{\phi_l}\right)^2 & \text{if } 0 \leq b \lt \phi_l \\ |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// \left(\frac{b - \phi_l}{\phi_l}\right)^2 & \text{if } 0 \leq b \lt \phi_l \\ | |
| /// \left(\frac{\phi_l - b}{\phi_l}\right)^2 & \text{if } 0 \leq b \lt \phi_l \\ |
Is this the correct way? The formula doesn't match the implementation
Contributor
Author
Contributor
Author
|
Will close this PR as the changes are already included in #36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All calculations for rebalancing incentive mechanism, precision loss are handled.
More info on the mechanism https://hackmd.io/_c9N1wV5RZ-VlpstKUaKjA