fix: serialize organization role mutations#29
Merged
Conversation
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
for_eachscenarioTriage
This is a provider bug. Organization role mutations operate on an organization-scoped priority order, while Terraform creates independent role resources concurrently. The provider previously sent those mutations without coordination.
The fix uses organization-scoped serialization instead of retrying create requests.
POSTis not documented as idempotent, so an automatic retry could duplicate or incorrectly adopt a role after partial server-side success.Testing
go test -race ./...go vet ./...go build ./...go generate ./...(clean diff)go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8 run ./...A live WorkOS acceptance regression is included but was not run locally because
WORKOS_API_KEYis not available in this environment.Closes #28