feat(imports): ignore files using inline script metadata#1546
Draft
mkniewallner wants to merge 1 commit intomainfrom
Draft
feat(imports): ignore files using inline script metadata#1546mkniewallner wants to merge 1 commit intomainfrom
mkniewallner wants to merge 1 commit intomainfrom
Conversation
mkniewallner
force-pushed
the
feat/ignore-inline-script-metadata-files
branch
from
5869af7 to
53ea26e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mkniewallner
force-pushed
the
feat/ignore-inline-script-metadata-files
branch
2 times, most recently
from
6ce6fdf to
33a321b
Compare
mkniewallner
force-pushed
the
feat/ignore-inline-script-metadata-files
branch
from
33a321b to
7252d60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1080.
PR Checklist
docsis updatedTODO:
Description of changes
Currently, deptry reads imports from Python files that use inline script metadata (also known as PEP 723). Since those files are self-contained, imports in there should not be considered as being part of the project, so they should be ignored.
Note that an issue exists for deptry to actually support inline script metadata (#1043), but even if this was to be implemented at some point, we would likely skip the imports for the main project the same way.