Relax valgrind suppression, enable 24.04 in CI #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the call stack related to the perceived memory leak related to stack allocation in threads has changed slightly in Ubuntu 24.04. This change relaxes that suppression slightly and enables 24.04 builds by default. Independently, this suppression needs to be relaxed in the same way to be applicable to std::thread instances used in testing, for which the same perceived leak manifests.
nuclearsandwich
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the call stack related to the perceived memory leak related to stack allocation in threads has changed slightly in Ubuntu 24.04. This change relaxes that suppression slightly and enables 24.04 builds by default.
Independently, this suppression needs to be relaxed in the same way to be applicable to std::thread instances used in testing, for which the same perceived leak manifests.