Add testing fixture for Assuan client and server #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixture starts a createrepo-agent server in a thread and connects a client to that server so that tests can be implemented to validate operations performed by the client.
cottsay
commented
Mar 21, 2025
Comment on lines
+21
to
+25
| TEST_P(smoke, commit) { | ||
| gpg_error_t rc = assuan_transact(client, "COMMIT", NULL, NULL, NULL, NULL, NULL, NULL); | ||
| EXPECT_FALSE(rc); | ||
| } | ||
| INSTANTIATE_TEST_SUITE_P( , smoke, testing::Values("empty", "populated"), smoke::PrintParamName); |
There was a problem hiding this comment.
This is a pretty bare example of how the fixture can be used.
In the test body, you have a running CRA server (in another thread) and an already connected client context. The fixture directory has already been copied to a temporary directory, so you can modify it as part of the test or test setup. The client and server will be terminated gracefully during the test tear-down.
Note that even though the CRA server has been started, it hasn't actually loaded any repository metadata, so you can absolutely modify it in the test body to set up the test as long as you haven't invoked any operations that would load the metadata first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixture starts a createrepo-agent server in a thread and connects a client to that server so that tests can be implemented to validate operations performed by the client.