fsm: Speed-up initial connection time #2878
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the existing implementation, the initial connection from GoBGP side was not attempted until the timer with a random value from the interval [5, 10) seconds expired. This change makes the initial connection attempt immediate, and lowers the minConnectRetryInterval to 1s. This helps to reduce convergence times, which is helpful especially in the datacenter deployment scenarios. Signed-off-by: Rastislav Szabo <[email protected]>
rastislavs
force-pushed
the
connect-speedup
branch
from
7f9e76b to
0cdaa2c
Compare
Member
|
Supposed to be closed? |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing implementation, the initial connection from GoBGP side was not attempted until the timer with a random value from the interval
[5, 10)seconds expired (derived from hardcodedminConnectRetryInterval, not configurable by any way).This change makes the initial connection attempt immediate, and lowers the
minConnectRetryIntervalto1s. This helps to reduce convergence times, which is helpful especially in the datacenter deployment scenarios.