packet/mrt: fix panic in PeerIndexTable parsing on large view name le… #3271
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngth parsePeerIndexTable used uint16 arithmetic for slice indices, which could wrap and cause data[6:5] panics. Compute view name boundaries using int indices and return errors safely. Add a regression test covering large view name lengths. Signed-off-by: FUJITA Tomonori <[email protected]>
fujita
force-pushed
the
fix-mrt-parser
branch
from
6d3bbab to
b015c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ngth
parsePeerIndexTable used uint16 arithmetic for slice indices, which could wrap and cause data[6:5] panics. Compute view name boundaries using int indices and return errors safely.
Add a regression test covering large view name lengths.