Skip to content

Fix vuln OSV-2023-1232 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oss-patch wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix vuln OSV-2023-1232 #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Packet++/src/SSLHandshake.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,11 +1204,27 @@ namespace pcpp
uint16_t extensionLength = getLength();
uint8_t listLength = *getData();
if (listLength != static_cast<uint8_t>(extensionLength - 1))
{
return result; // bad extension data
}

// Ensure listLength is within valid bounds
if (listLength > extensionLength - 1)
{
return result; // Prevent out-of-bounds access
}

return result; // bad extension data

uint8_t* dataPtr = getData() + sizeof(uint8_t);
for (int i = 0; i < listLength; i++)
{
// Ensure dataPtr does not exceed allocated memory
if (dataPtr >= getData() + extensionLength)
{
break; // Prevent out-of-bounds access
}

result.push_back(*dataPtr);
dataPtr += sizeof(uint8_t);
}
Expand Down
Loading