Skip to content

Fix handling of virtual packages in Yarn2 #11208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnonnenmacher merged 2 commits into from
May 5, 2026
+313 −44
Merged

Fix handling of virtual packages in Yarn2 #11208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec76c69
test(yarn2): Use a dependency with normal and peer dependencies
mnonnenmacher Dec 7, 2025
af6c54e
fix(yarn2): Capture transitive dependencies of packages with peer deps
mnonnenmacher Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 72 additions & 15 deletions ...ode/src/funTest/assets/projects/synthetic/yarn2/project-with-lockfile-expected-output.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ project:
- id: "NPM::promise:7.3.1"
dependencies:
- id: "NPM::asap:2.0.6"
- id: "NPM:@react-native-community:netinfo:11.2.1"
- id: "NPM:@csstools:css-color-parser:3.0.8"
dependencies:
Comment thread
mnonnenmacher marked this conversation as resolved.
- id: "NPM:@csstools:color-helpers:5.1.0"
- id: "NPM:@csstools:css-calc:2.1.4"
- name: "devDependencies"
dependencies:
- id: "NPM::cson:4.1.0"
Expand Down Expand Up @@ -1266,36 +1269,90 @@ packages:
url: "https://github.com/TooTallNate/util-deprecate.git"
revision: "475fb6857cd23fafff20c1be846c1350abf8e6d4"
path: ""
- id: "NPM:@react-native-community:netinfo:11.2.1"
purl: "pkg:npm/%40react-native-community/netinfo@11.2.1"
authors:
- "Matt Oakes"
- id: "NPM:@csstools:color-helpers:5.1.0"
purl: "pkg:npm/%40csstools/color-helpers@5.1.0"
declared_licenses:
- "MIT-0"
declared_licenses_processed:
spdx_expression: "MIT-0"
description: "Color helpers to ease transformation between formats, gamut, etc"
homepage_url: "https://github.com/csstools/postcss-plugins/tree/main/packages/color-helpers#readme"
binary_artifact:
url: ""
hash:
value: ""
algorithm: ""
source_artifact:
url: "https://registry.npmjs.org/@csstools/color-helpers/-/color-helpers-5.1.0.tgz"
hash:
value: "106c54c808cabfd1ab4c602d8505ee584c2996ef"
algorithm: "SHA-1"
vcs:
type: "Git"
url: "git+https://github.com/csstools/postcss-plugins.git"
revision: "132530a36b9f711a886602ce4bf1e95de95f2a5b"
path: "packages/color-helpers"
vcs_processed:
type: "Git"
url: "https://github.com/csstools/postcss-plugins.git"
revision: "132530a36b9f711a886602ce4bf1e95de95f2a5b"
path: "packages/color-helpers"
- id: "NPM:@csstools:css-calc:2.1.4"
purl: "pkg:npm/%40csstools/css-calc@2.1.4"
declared_licenses:
- "MIT"
declared_licenses_processed:
spdx_expression: "MIT"
description: "React Native Network Info API for iOS & Android"
homepage_url: "https://github.com/react-native-netinfo/react-native-netinfo#readme"
description: "Solve CSS math expressions"
homepage_url: "https://github.com/csstools/postcss-plugins/tree/main/packages/css-calc#readme"
binary_artifact:
url: ""
hash:
value: ""
algorithm: ""
source_artifact:
url: "https://registry.npmjs.org/@react-native-community/netinfo/-/netinfo-11.2.1.tgz"
url: "https://registry.npmjs.org/@csstools/css-calc/-/css-calc-2.1.4.tgz"
hash:
value: "177f5409f2ac41fd51ede6e4994307bb0edb2178"
value: "8473f63e2fcd6e459838dd412401d5948f224c65"
algorithm: "SHA-1"
vcs:
type: "Git"
url: "https://github.com/react-native-netinfo/react-native-netinfo.git"
revision: "736138c36eeebb0a320f8eccd263f909855f5c75"
path: ""
url: "git+https://github.com/csstools/postcss-plugins.git"
revision: "7a21bdf28305a0915af8e002b98ba82bc25a1573"
path: "packages/css-calc"
vcs_processed:
type: "Git"
url: "https://github.com/react-native-netinfo/react-native-netinfo.git"
revision: "736138c36eeebb0a320f8eccd263f909855f5c75"
path: ""
url: "https://github.com/csstools/postcss-plugins.git"
revision: "7a21bdf28305a0915af8e002b98ba82bc25a1573"
path: "packages/css-calc"
- id: "NPM:@csstools:css-color-parser:3.0.8"
purl: "pkg:npm/%40csstools/css-color-parser@3.0.8"
declared_licenses:
- "MIT"
declared_licenses_processed:
spdx_expression: "MIT"
description: "Parse CSS color values"
homepage_url: "https://github.com/csstools/postcss-plugins/tree/main/packages/css-color-parser#readme"
binary_artifact:
url: ""
hash:
value: ""
algorithm: ""
source_artifact:
url: "https://registry.npmjs.org/@csstools/css-color-parser/-/css-color-parser-3.0.8.tgz"
hash:
value: "5fe9322920851450bf5e065c2b0e731b9e165394"
algorithm: "SHA-1"
vcs:
type: "Git"
url: "git+https://github.com/csstools/postcss-plugins.git"
revision: "1e7b98202406e4041a9dae1629ec9272138fd77f"
path: "packages/css-color-parser"
vcs_processed:
type: "Git"
url: "https://github.com/csstools/postcss-plugins.git"
revision: "1e7b98202406e4041a9dae1629ec9272138fd77f"
path: "packages/css-color-parser"
- id: "NPM:@types:node:22.9.0"
purl: "pkg:npm/%40types/node@22.9.0"
declared_licenses:
Expand Down
87 changes: 72 additions & 15 deletions ...s/projects/synthetic/yarn2/project-with-lockfile-skip-excluded-scopes-expected-output.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ project:
- id: "NPM::promise:7.3.1"
dependencies:
- id: "NPM::asap:2.0.6"
- id: "NPM:@react-native-community:netinfo:11.2.1"
- id: "NPM:@csstools:css-color-parser:3.0.8"
dependencies:
- id: "NPM:@csstools:color-helpers:5.1.0"
- id: "NPM:@csstools:css-calc:2.1.4"
packages:
- id: "NPM::asap:2.0.6"
purl: "pkg:npm/asap@2.0.6"
Expand Down Expand Up @@ -851,36 +854,90 @@ packages:
url: "https://github.com/TooTallNate/util-deprecate.git"
revision: "475fb6857cd23fafff20c1be846c1350abf8e6d4"
path: ""
- id: "NPM:@react-native-community:netinfo:11.2.1"
purl: "pkg:npm/%40react-native-community/netinfo@11.2.1"
authors:
- "Matt Oakes"
- id: "NPM:@csstools:color-helpers:5.1.0"
purl: "pkg:npm/%40csstools/color-helpers@5.1.0"
declared_licenses:
- "MIT-0"
declared_licenses_processed:
spdx_expression: "MIT-0"
description: "Color helpers to ease transformation between formats, gamut, etc"
homepage_url: "https://github.com/csstools/postcss-plugins/tree/main/packages/color-helpers#readme"
binary_artifact:
url: ""
hash:
value: ""
algorithm: ""
source_artifact:
url: "https://registry.npmjs.org/@csstools/color-helpers/-/color-helpers-5.1.0.tgz"
hash:
value: "106c54c808cabfd1ab4c602d8505ee584c2996ef"
algorithm: "SHA-1"
vcs:
type: "Git"
url: "git+https://github.com/csstools/postcss-plugins.git"
revision: "132530a36b9f711a886602ce4bf1e95de95f2a5b"
path: "packages/color-helpers"
vcs_processed:
type: "Git"
url: "https://github.com/csstools/postcss-plugins.git"
revision: "132530a36b9f711a886602ce4bf1e95de95f2a5b"
path: "packages/color-helpers"
- id: "NPM:@csstools:css-calc:2.1.4"
purl: "pkg:npm/%40csstools/css-calc@2.1.4"
declared_licenses:
- "MIT"
declared_licenses_processed:
spdx_expression: "MIT"
description: "React Native Network Info API for iOS & Android"
homepage_url: "https://github.com/react-native-netinfo/react-native-netinfo#readme"
description: "Solve CSS math expressions"
homepage_url: "https://github.com/csstools/postcss-plugins/tree/main/packages/css-calc#readme"
binary_artifact:
url: ""
hash:
value: ""
algorithm: ""
source_artifact:
url: "https://registry.npmjs.org/@react-native-community/netinfo/-/netinfo-11.2.1.tgz"
url: "https://registry.npmjs.org/@csstools/css-calc/-/css-calc-2.1.4.tgz"
hash:
value: "177f5409f2ac41fd51ede6e4994307bb0edb2178"
value: "8473f63e2fcd6e459838dd412401d5948f224c65"
algorithm: "SHA-1"
vcs:
type: "Git"
url: "https://github.com/react-native-netinfo/react-native-netinfo.git"
revision: "736138c36eeebb0a320f8eccd263f909855f5c75"
path: ""
url: "git+https://github.com/csstools/postcss-plugins.git"
revision: "7a21bdf28305a0915af8e002b98ba82bc25a1573"
path: "packages/css-calc"
vcs_processed:
type: "Git"
url: "https://github.com/react-native-netinfo/react-native-netinfo.git"
revision: "736138c36eeebb0a320f8eccd263f909855f5c75"
path: ""
url: "https://github.com/csstools/postcss-plugins.git"
revision: "7a21bdf28305a0915af8e002b98ba82bc25a1573"
path: "packages/css-calc"
- id: "NPM:@csstools:css-color-parser:3.0.8"
purl: "pkg:npm/%40csstools/css-color-parser@3.0.8"
declared_licenses:
- "MIT"
declared_licenses_processed:
spdx_expression: "MIT"
description: "Parse CSS color values"
homepage_url: "https://github.com/csstools/postcss-plugins/tree/main/packages/css-color-parser#readme"
binary_artifact:
url: ""
hash:
value: ""
algorithm: ""
source_artifact:
url: "https://registry.npmjs.org/@csstools/css-color-parser/-/css-color-parser-3.0.8.tgz"
hash:
value: "5fe9322920851450bf5e065c2b0e731b9e165394"
algorithm: "SHA-1"
vcs:
type: "Git"
url: "git+https://github.com/csstools/postcss-plugins.git"
revision: "1e7b98202406e4041a9dae1629ec9272138fd77f"
path: "packages/css-color-parser"
vcs_processed:
type: "Git"
url: "https://github.com/csstools/postcss-plugins.git"
revision: "1e7b98202406e4041a9dae1629ec9272138fd77f"
path: "packages/css-color-parser"
- id: "NPM:@types:node:22.9.0"
purl: "pkg:npm/%40types/node@22.9.0"
declared_licenses:
Expand Down
2 changes: 1 addition & 1 deletion ...agers/node/src/funTest/assets/projects/synthetic/yarn2/project-with-lockfile/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"author": "The Author <the.author@mail.example> (https://www.the.author.example/index.html)",
"private": true,
"dependencies": {
"@react-native-community/netinfo": "11.2.1",
"@csstools/css-color-parser": "3.0.8",
Comment thread
sschuberth marked this conversation as resolved.
"cheerio": "1.0.0-rc.1",
"long": "^3.2.0"
},
Expand Down
41 changes: 31 additions & 10 deletions ...managers/node/src/funTest/assets/projects/synthetic/yarn2/project-with-lockfile/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,40 @@ __metadata:
version: 6
cacheKey: 8

"@lmdb/lmdb-darwin-arm64@npm:3.0.13":
version: 3.0.13
resolution: "@lmdb/lmdb-darwin-arm64@npm:3.0.13"
conditions: os=darwin & cpu=arm64
"@csstools/color-helpers@npm:^5.0.2":
version: 5.1.0
resolution: "@csstools/color-helpers@npm:5.1.0"
checksum: 2b1cef009309c30c6e6e904d259e809761a8482fe262b000dacc159d94bcd982d59d85baea449de0fd57afc98b7fc19561ffe756d2b679d56a39c48c2b9c556a
languageName: node
linkType: hard

"@csstools/css-calc@npm:^2.1.2":
version: 2.1.4
resolution: "@csstools/css-calc@npm:2.1.4"
peerDependencies:
"@csstools/css-parser-algorithms": ^3.0.5
"@csstools/css-tokenizer": ^3.0.4
checksum: b833d1a031dfb3e3268655aa384121b864fce9bad05f111a3cf2a343eed69ba5d723f3f7cd0793fd7b7a28de2f8141f94568828f48de41d86cefa452eee06390
languageName: node
linkType: hard

"@react-native-community/netinfo@npm:11.2.1":
version: 11.2.1
resolution: "@react-native-community/netinfo@npm:11.2.1"
"@csstools/css-color-parser@npm:3.0.8":
version: 3.0.8
resolution: "@csstools/css-color-parser@npm:3.0.8"
dependencies:
"@csstools/color-helpers": ^5.0.2
"@csstools/css-calc": ^2.1.2
peerDependencies:
react-native: ">=0.59"
checksum: d54b75c6dc6d7a8cbb054d84ed9326e1715259137e333f26cd801c6b820996cacceb5a1cf3ee94b91866361c040b7a12eb78db3695b076e8f30c3403985f98d5
"@csstools/css-parser-algorithms": ^3.0.4
"@csstools/css-tokenizer": ^3.0.3
checksum: 7e04e821b8ad422c888ed03d5d9d7960a54bc19c5386dd1796da3b782940c3ea90136971d374b42fe7d7111f096941f8bbe7520fa591fb716c73b5b2f4f0cedb
languageName: node
linkType: hard

"@lmdb/lmdb-darwin-arm64@npm:3.0.13":
version: 3.0.13
resolution: "@lmdb/lmdb-darwin-arm64@npm:3.0.13"
conditions: os=darwin & cpu=arm64
languageName: node
linkType: hard

Expand Down Expand Up @@ -378,8 +399,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "yarn2-package-with-lockfile@workspace:."
dependencies:
"@csstools/css-color-parser": 3.0.8
"@lmdb/lmdb-darwin-arm64": 3.0.13
"@react-native-community/netinfo": 11.2.1
cheerio: 1.0.0-rc.1
cson: ~4.1.0
long: ^3.2.0
Expand Down
Loading
Loading