Resolve a jetty-http vulnerability#11304
Conversation
None of these vulnerabilities is still present in ORT, thus the resolutions match nothing and can be removed. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
0b930d6 to
6864921
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11304 +/- ##
=========================================
Coverage 57.41% 57.41%
Complexity 1705 1705
=========================================
Files 346 346
Lines 12875 12875
Branches 1228 1228
=========================================
Hits 7392 7392
Misses 5005 5005
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| reason: "INEFFECTIVE_VULNERABILITY" | ||
| comment: >- | ||
| The vulnerable package 'Maven:org.eclipse.jetty:jetty-http:11.0.26' is introduced as a transitive dependency of 'Maven:org.wiremock:wiremock:3.13.2' | ||
| which is a package exclusively used for testing and thus is neither distributed nor exploitable in a deployment. |
There was a problem hiding this comment.
Is it possible to setup excludes such that this is not queried in the first place? (e.g. scope excludes?)
There was a problem hiding this comment.
Thinking about this again, while it's correct that the vulnerability could also be "configured away" by creating a scope exclude for all tests scopes and running the advisor with skipExcluded = true, I wonder whether that's what we want, as it would suppress any vulnerability in a test dependency. But maybe our aspiration for our own code base is to even go through vulnerabilities in test dependencies and resolve them on a case by case basis?
In a way, the question boils down to which "distribution type" we'd like to assume / apply when running ORT on ORT. This is probably something we could discuss in a meeting.

Please have a look at the individual commit messages for the details.