feat(model): Add indicator nodes for cycles in the dependency graph#11627
Open
oheger-bosch wants to merge 1 commit into
Open
feat(model): Add indicator nodes for cycles in the dependency graph#11627oheger-bosch wants to merge 1 commit into
oheger-bosch wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11627 +/- ##
============================================
+ Coverage 58.30% 58.49% +0.18%
- Complexity 1766 1816 +50
============================================
Files 356 362 +6
Lines 13275 13521 +246
Branches 1323 1385 +62
============================================
+ Hits 7740 7909 +169
- Misses 5047 5114 +67
- Partials 488 498 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oheger-bosch
force-pushed
the
oheger-bosch/dependency_graph_cycle_nodes
branch
from
d068876 to
f8f4c31
Compare
oheger-bosch
force-pushed
the
oheger-bosch/dependency_graph_cycle_nodes
branch
from
f8f4c31 to
ab535d6
Compare
Member
Author
|
The approach has been verified against a real-life Yarn2 project that has a cyclic dependency. |
When during construction of the dependency graph a cycle in the dependencies is detected, add a special marker node for the package that closes the cycle that does not have any dependencies. That way, the referenced package is still visible in the graph, but the graph remains free of cycles. Signed-off-by: Oliver Heger <oliver.heger@bosch.com>
oheger-bosch
force-pushed
the
oheger-bosch/dependency_graph_cycle_nodes
branch
from
ab535d6 to
954b8ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When during construction of the dependency graph a cycle in the dependencies is detected, add a special marker node for the package that closes the cycle that does not have any dependencies. That way, the referenced package is still visible in the graph, but the graph remains free of cycles.