Fix/bazel parser#11826
Conversation
losmateusz1
commented
May 12, 2026
- Add variable definition parsing inside Module.bazel
- Add more verbose logs when unsupported configuration is found
0e6793b to
3814da7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11826 +/- ##
=========================================
Coverage 58.43% 58.43%
Complexity 1809 1809
=========================================
Files 361 361
Lines 13499 13499
Branches 1383 1383
=========================================
Hits 7888 7888
Misses 5115 5115
Partials 496 496
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3814da7 to
39ba368
Compare
19fbdee to
bdc27c1
Compare
sschuberth
left a comment
There was a problem hiding this comment.
@nnobelis, please also have a look.
bdc27c1 to
625ae23
Compare
81dafb8 to
ed71738
Compare
|
|
||
| package org.ossreviewtoolkit.plugins.packagemanagers.bazel | ||
|
|
||
| import org.ossreviewtoolkit.utils.common.enumSetOf |
There was a problem hiding this comment.
Commit message: Here, the first "Bazel" should be "bazel" (as it refers to the scope / directory name), and the second "bazel" should be "Bazel" (as it refers to the build system name) 😆
There was a problem hiding this comment.
Also, please explain in the commit message what's the effect of adding variable parsing. Does it avoid an exception? Or does it provide more data now? What else?
e75853e to
1ec446a
Compare
There was a problem hiding this comment.
The MODULE.bazel.lock files should not be deleted as part of this commit.
There was a problem hiding this comment.
in my opinion we shouldn't keep lock files in repository, as they are regenerated during tests anyway. After running all tests we are generating more lockfiles than those already in the repository, so I am not sure why we should keep those two specifically, they are not being used for anything in other tests
for now I just moved removals to separate commit, I thought that this is what you are requesting :)
There was a problem hiding this comment.
I am not sure why we should keep those two specifically, they are not being used for anything in other tests
I believe they're need for getting reproducible results in tests even if new version of dependencies have been published, correct @nnobelis?
Anyway, even if removing them, that must be done in a separate commit with a dedicated rationale.
There was a problem hiding this comment.
it is in separate commit now, would you like me to remove it from here and add separate PR for the cleanup?
Signed-off-by: Mateusz Los <mateusz.los@extern.wenovate.de>
Signed-off-by: Mateusz Los <mateusz.los@extern.wenovate.de>
Signed-off-by: Mateusz Los <mateusz.los@extern.wenovate.de>
Signed-off-by: Mateusz Los <mateusz.los@extern.wenovate.de>
1ec446a to
cd77d67
Compare