refactor(gradle)!: Split out authentication utilities to a new module#11925
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11925 +/- ##
============================================
- Coverage 58.60% 58.42% -0.19%
+ Complexity 1809 1807 -2
============================================
Files 359 361 +2
Lines 13387 13491 +104
Branches 1355 1382 +27
============================================
+ Hits 7846 7882 +36
- Misses 5049 5114 +65
- Partials 492 495 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6665709 to
8377be6
Compare
|
Regarding the 2nd commit, I'm not sure about all filename changes. In particular, for Utils, which only have very few functions in it, this refactoring in my view may be a little bit early, because it becomes clearer what utilities will be about once it has grown a bit further. Also in some cases this name introduces redundancy. E.g. in case of NodeUtils. What do you think? (maybe it's worth to split out this commit) Also, does this approach really fix an issue with finding things in IDE. It maybe be just me, but I wouldn't be able to remember the filenames corresponding to a function of all these more specific utility filenames anymay. |
I get what you mean. But to some extend, I believe it could also be good to require us thinking a bit mode about modularity and proper grouping of functions (by functionality, not by type).
I agree that "Node" is a bit redundant, but we already have such "doubling" e.g. in So I weighted disambiguation higher than getting rid of a bit of redundancy.
I don't think that's required. All but one renaming keep "Utils" as part of the filename, so you would still only need to search for "Utils", but get more telling names in the search results. |
This allows for more fine-granular dependency management. BREAKING CHANGE: Programmatic users might need to depend on `authorization-utils` instead of / in addition to `ort-utils` now. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
Allow to more easily distinguish these, e.g. in IDE file search. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
This allows for more fine-granular dependency management.
BREAKING CHANGE: Programmatic users might need to depend on
authorization-utilsinstead of / in addition toort-utilsnow.