Skip to content

Fix Tycho analysis for Java >= 24#11930

Merged
sschuberth merged 2 commits into
mainfrom
tycho-jaxp-vs-java24
Jun 2, 2026
Merged

Fix Tycho analysis for Java >= 24#11930
sschuberth merged 2 commits into
mainfrom
tycho-jaxp-vs-java24

Conversation

@sschuberth
Copy link
Copy Markdown
Member

Please have a look at the individual commit messages for the details.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
In Java >= 24, the default limit for processing XML entities was
significantly lowered to 100000 bytes to protect against Entity Expansion
/ Billion Laughs Denial of Service attacks. Repeal that limit in the
context of Tycho processing to avoid errors during analysis.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.io>
@sschuberth sschuberth requested a review from a team as a code owner June 2, 2026 15:58
@sschuberth sschuberth enabled auto-merge (rebase) June 2, 2026 15:58
@sschuberth sschuberth changed the title Fix Tycho abalysis for Java >= 24 Fix Tycho analysis for Java >= 24 Jun 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.43%. Comparing base (71d5687) to head (0232f1f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...kage-managers/maven/src/main/kotlin/tycho/Tycho.kt 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11930      +/-   ##
============================================
+ Coverage     58.41%   58.43%   +0.01%     
- Complexity     1807     1809       +2     
============================================
  Files           361      361              
  Lines         13491    13499       +8     
  Branches       1382     1383       +1     
============================================
+ Hits           7881     7888       +7     
- Misses         5114     5115       +1     
  Partials        496      496              
Flag Coverage Δ
funTest-external-tools 14.64% <0.00%> (-0.02%) ⬇️
funTest-no-external-tools 30.37% <85.71%> (+0.13%) ⬆️
test-ubuntu-24.04 41.78% <85.71%> (+0.02%) ⬆️
test-windows-2025 41.76% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sschuberth sschuberth merged commit 4cc2fbe into main Jun 2, 2026
31 of 32 checks passed
@sschuberth sschuberth deleted the tycho-jaxp-vs-java24 branch June 2, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants