refactor(settings): Normalize setttings to match pydantic #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
heliocastro
commented
Jul 5, 2024
heliocastro
commented
- Refactored config naming to settings to match pydantic settings naming structure.
- Enabled .env / .env.prod evaluation capability .
- Add ORTHW_CONFIG_DIR and ORTHW_CONFIG_FILE variables that can be evaluated in runtime bypassing as environment file or inside .env. The variables are case sensitive.
heliocastro
force-pushed
the
heliocastro/config
branch
from
47e3691 to
46f8815
Compare
- Refactored config naming to settings to match pydantic settings naming structure. - Enabled .env / .env.prod evaluation capability . - Add ORTHW_CONFIG_DIR and ORTHW_CONFIG_FILE variables that can be evaluated in runtime bypassing as environment file or inside .env. The variables are case sensitive. Signed-off-by: Helio Chissini de Castro <[email protected]>
heliocastro
force-pushed
the
heliocastro/config
branch
from
46f8815 to
87be411
Compare
tsteenbe
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.