first set of unit tests for ThermistorHelper - #366
Closed
ThomasPautler952194 wants to merge 2 commits into
Closed
Conversation
9 tasks
|
|
j-heitz
reviewed
Sep 17, 2025
| @@ -7,7 +7,7 @@ public class ThermistorHelperTest { | |||
|
|
|||
| @Test | |||
| void testBasicFunctionality() { | |||
Collaborator
There was a problem hiding this comment.
This test will always pass since it’s just assertTrue(true). It’s useful as a quick sanity check that JUnit is set up correctly, but it doesn’t exercise any actual functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is my submission for spring 1, it adds the ThermistorHelperTest.java that contains 2 of the tests required, both of these tests pass and work as indented as far as i know.