Merge main - #410
Conversation
Reverted Back the workflow changes
…s, added troubleshooting info and a couple build instructions
Added github workflows into the build_library
…dule-for-pi4micronaut' into 263-document-dc-motor-control-module-for-pi4micronaut
…dule-for-pi4micronaut DC Motor documentation
Added Speed Sensor Documentation
…lper with four displays initialized.
…ntative implementation of single-digit seven-segment display helper.
…naut-44 # Conflicts: # components/src/main/resources/application.yml
…orrect type, added tests
Update developers list
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Leandru Martin <122942864+leandrumartin@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Leandru Martin <122942864+leandrumartin@users.noreply.github.com>
…om/oss-slu/Pi4Micronaut into 395-improve-issue-and-pr-templates
Add PR templates
Fix(tests): Rename MicroSwitchHelperTests file to .java
Add ShiftRegister74HC595Helper for SPI-based shift register control
Add root-level build.gradle to resolve shared plugins across projects
Docs: Organize component list in index.adoc
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| runs-on: ubuntu-latest | ||
| name: Paper Draft | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Build draft PDF | ||
| uses: openjournals/openjournals-draft-action@master | ||
| with: | ||
| journal: joss | ||
| # This should be the path to the paper within your repo. | ||
| paper-path: joss-paper/paper.md | ||
| - name: Upload | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: paper | ||
| # This is the output path where Pandoc will write the compiled | ||
| # PDF. Note, this should be the same directory as the input | ||
| # paper.md | ||
| path: joss-paper/paper.pdf |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 10 months ago
To fix the problem, we should explicitly define a permissions block in the workflow YAML. This can be done either at the top level (applies globally) or at the job level for finer control. Since the workflow shown consists of one job ("paper") and does not perform any repository write actions (e.g., no pushes, PRs, or issue creation), the minimal permissions required are most likely contents: read. To implement the fix, add a permissions: section with contents: read at the root level, just after on: and before jobs:. No modifications to individual steps are needed. This improves security by making least-privilege explicit.
| @@ -7,6 +7,8 @@ | ||
| - joss-paper/** | ||
| - .github/workflows/draft-pdf.yml | ||
|
|
||
| permissions: | ||
| contents: read | ||
| jobs: | ||
| paper: | ||
| runs-on: ubuntu-latest |
14 participants
Pull Request Summary
Merged
maininto the branch and fixed merge conflicts. In virtually all conflicts, the changes frommainwere accepted, as they were more recent and improved (upped version numbers, better error checking).PR Checklist