Make setLog private for internal testing - #412
Merged
Merged
Conversation
|
|
leandrumartin
requested changes
Oct 21, 2025
leandrumartin
left a comment
leandrumartin
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for your contribution! There just needs to be slight changes to make sure the comments fit Javadoc formatting.
leandrumartin
approved these changes
Oct 21, 2025
leandrumartin
left a comment
leandrumartin
left a comment
Collaborator
There was a problem hiding this comment.
Looks good now. Thank you for your contribution!
leandrumartin
added
the
hacktoberfest-accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR makes the setLog methods in helper classes (such as FourDigitSevenSegmentDisplayHelper, LEDHelper, UltraSonicSensorHelper, and ServoMotorHelper) package private instead of public.
PR Checklist
Detailed Description
Previously, these methods were public so that unit tests could inject mock Logger objects. However, this made it possible for external users of the library to override the logger which is unnecessary.
They are now only accessible within the package and remain usable for internal tests.