fix: use deploy key instead of token for gh-pages deployment - #483
Merged
leandrumartin merged 2 commits intoMay 25, 2026
Merged
Conversation
Contributor
Author
|
please review and merge . |
This was referenced Apr 11, 2026
leandrumartin
approved these changes
May 25, 2026
Signed-off-by: Leandru Martin <122942864+leandrumartin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #461
Root Cause
The deploy step was using
GITHUB_TOKENwhich does not have admin accessand cannot bypass branch protection rules on the
gh-pagesbranch.Changes in
javadoc-gh-pages.ymlgithub_token: ${{ secrets.GITHUB_TOKEN }}withdeploy_key: ${{ secrets.ACTIONS_DEPLOY_KEY }}to allow bypassingbranch protection rules on
gh-pagesif: github.ref == 'refs/heads/develop'so deployment alsoruns on
mainuser_nameanduser_emailas they are not needed with adeploy key