Skip to content

fix(common): decode the crop view image at screen resolution #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
farfromrefug merged 1 commit into from
Sep 10, 2026
+4 −3
Merged

fix(common): decode the crop view image at screen resolution #720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/components/common/CropView.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<script context="module" lang="ts">
import { BitmapShader, Canvas, CanvasView, Matrix, Paint, Path, Style, TileMode } from '@nativescript-community/ui-canvas';
import { ApplicationSettings, ImageSource, Screen, TouchGestureEventData, Utils } from '@nativescript/core';
import { ApplicationSettings, ImageSource, TouchGestureEventData, Utils } from '@nativescript/core';
import { debounce } from '@nativescript/core/utils';
import { QRCodeData, QuadPoint, Quads } from 'plugin-nativeprocessor';
import { onDestroy } from 'svelte';
import { NativeViewElementNode } from '@nativescript-community/svelte-native/dom';
import { MAGNIFIER_SENSITIVITY, SETTINGS_MAGNIFIER_SENSITIVITY } from '~/utils/constants';
import { IMAGE_DECODE_HEIGHT, MAGNIFIER_SENSITIVITY, SETTINGS_MAGNIFIER_SENSITIVITY } from '~/utils/constants';
import { loadImage, recycleImages } from '~/utils/images';
import { showError } from '@shared/utils/showError';
import { createEventDispatcher } from '@shared/utils/svelte/ui';
Expand All @@ -14,7 +14,8 @@
import { colorTheme, isEInk } from '~/helpers/theme';
const padding = 20;
const ZOOOM_GLASS_SIZE = 50;
const ZOOM_IMAGE_MAX_SIZE = Math.max(Screen.mainScreen.widthDIPs, Screen.mainScreen.heightDIPs);
// in pixels: it is used as a decode size, both for `loadImage` and for the image view
const ZOOM_IMAGE_MAX_SIZE = IMAGE_DECODE_HEIGHT;

declare namespace svelteNative.JSX {
interface ViewAttributes {
Expand Down
Loading